[codex] Avoid shell for Node executable spawns#2952
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
github-actions
Bot
added
vouch:trusted
Contributor
|
🚀 Expo continuous deployment is ready!
|
J-Giggles
pushed a commit
to J-Giggles/t3code
that referenced
this pull request
Jun 5, 2026
Co-authored-by: Julius Marminge <julius@mac.lan> (cherry picked from commit a74dfd4)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes Windows shell mode from launches that execute Node itself.
Details
process.execPath, which is the current Node executable path and does not require shell lookup.process.execPath; this removes the stale shell flag/comment from that direct Node invocation.npmand provider/agent command launches are intentionally left shell-backed because they may resolve through.cmdshims on Windows.Validation
vp checkpassed. It reported existingreact(no-unstable-nested-components)warnings outside this change.vp run typecheckpassed.Note
Replace hardcoded
nodestring withprocess.execPathfor child process spawnsReplaces the string
"node"withprocess.execPathand removes the Windows-only shell mode option in allChildProcess.makecalls across the build script and test utilities. This ensures the correct Node binary is used at runtime rather than relying on PATH resolution.Macroscope summarized 2a8ff34.
Note
Low Risk
Test and build-only spawn options; no auth, data, or production runtime behavior beyond more reliable Node invocation on Windows.
Overview
Child process spawns that run Node directly now use
process.execPathinstead of thenodecommand and no longer passshell: trueon Windows.The server build CLI already invoked Node via
process.execPath; this drops the leftover Windows shell option and comment from thatChildProcess.makecall. ACP and Codex app-server integration tests spawn mock peers the same way, so tests use the current Node binary without shell-based PATH lookup.npm publish and other launches that may resolve
.cmdshims on Windows are unchanged and still use shell mode where needed.Reviewed by Cursor Bugbot for commit 2a8ff34. Bugbot is set up for automated code reviews on this repo. Configure here.